Legacy Widget: Ensure the control form's IDs have a consistent number #31485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
noisysocks
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +51 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Base automatically changed from
try/refactor-legacy-widget-to-not-use-react
to
trunk
May 5, 2021 06:42
noisysocks
force-pushed
the
fix/legacy-widget-ids
branch
from
a61b9e5 to
5bdb6dd
Compare
|
Wow! Thanks @noisysocks. |
|
Thanks for the really good instructions and sample code @manooweb! |
|
@noisysocks, @talldan It seems ok 👍 to me on the trunk and with the legacy widget example I provided. Wait for 10.6.x release and my other tests to confirm however it seems good. |
|
@noisysocks, @talldan it's ok for me with Gutenberg 10.6.1, I was able to adapt our jQuery javascript code of our legacy widget fields and make it work as expected. However I have another problem with the preview in the iframe but it's something else that doesn't concern this current PR and issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28668.
Requires #31444.
Ensures that all of the IDs in a Legacy Widget block's form's inputs have the same number.
/widget-types/:type/encodeendpoint to accept anumberparam which controls the number used to generate the widget HTML that is returned.Controlto send its fakenumberto the endpoint so that all of the form fields in the control have a consistent ID.How has this been tested?
Follow the steps in #28668 (comment).
Checklist:
*.native.jsfiles for terms that need renaming or removal).