-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docgen: split getIntermediateRepresentation
unit tests in smaller tests
#31468
Docgen: split getIntermediateRepresentation
unit tests in smaller tests
#31468
Conversation
…sts into smaller tests
…t / named export" test
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ciampo! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @ciampo 👍 !
Description
The
getIntermediateRepresentation
unit tests currently have a lot of assertions per test, making them hard to read and debug in case of failure.This PR aims at splitting the assertion into smaller tests.
The actual code for the tests hasn't been updated. The main changes are:
describe
around most testsMost of the diff changes are caused by the change in indentation.
How has this been tested?
npm run test-unit packages/docgen
getIntermediateRepresentation
is more granularScreenshots
N/A
Types of changes
Refactor
Checklist:
*.native.js
files for terms that need renaming or removal).