Unify the post tags and post categories block under a unique post terms block. #31458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Blocks
youknowriad
requested review from
scruffian,
mtias,
jameskoster,
jasmussen and
carolinan
youknowriad
requested review from
ajitbohra,
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +166 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
May 4, 2021
There was a problem hiding this comment.
These blocks are still experimental, they might be used by some experimental FSE blocks already but I think such a change is needed at the moment.
IMO it's good timing to tidy things up before making this block stable.
Code wise besides the small comments this looks good 👍
A thing that was before in PostHierarchicalTerms block is the usage of BlockVariationPicker which was not actually used as we had set isDefault to a variation. Same goes here and I don't see any reason not to remove this. Any thoughts?
| name: 'post_tag', | ||
| title: __( 'Post Tags' ), | ||
| description: __( "Display a post's tags." ), | ||
| icon, |
There was a problem hiding this comment.
We need to set tag icon here.
There was a problem hiding this comment.
We have both a category and post-categories icons, we probably need the same for tags which we don't have right now. Maybe a good design follow-up. cc @jasmussen
There was a problem hiding this comment.
I've set a reminder to follow up here.
I think the reason we have this is that we don't want to show the |
I know and it makes sense, what I'm suggesting is that we could remove |
|
Oh got it @ntsekouras it should be done now. |
ntsekouras
reviewed
May 5, 2021
ntsekouras
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31422
This PR does a few things:
These blocks are still experimental, they might be used by some experimental FSE blocks already but I think such a change is needed at the moment.
What do you think?