Nav block placeholder, fix font inheritance #31410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +194 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
priethor
added
[Block] Navigation
|
Hmm do we have an open issue for the nav inserter on the site editor?
|
gwwar
approved these changes
May 4, 2021
|
Thanks so much, I'll land this one!
There was some recent discussion about it in the core slack, but I'm not sure where that landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31353. Somehow regressed from #30011.
Explicitly sets the font on the navigation block setup state so that it is correctly applied to buttons inside.
How has this been tested?
Test primarily the site editor. The issue is also present in the post editor, but there it is only affecting the block type indicator.
Insert a navigation block, and without adding any menu items, set the font family to something other than default.
Before:
After:
Also verify that when you later on add pages, they are set in the custom font chosen.
Checklist:
*.native.jsfiles for terms that need renaming or removal).