-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components: Remove wp-g2 from flex, vstack, hstack, spinner and contr… #31243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
/packages/components
[Feature] Component System
WordPress component system
labels
Apr 27, 2021
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
April 27, 2021 14:36
youknowriad
approved these changes
Apr 27, 2021
Size Change: +36 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
remove/wp-g2-rest
branch
from
April 27, 2021 14:59
5431666
to
59d61fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ol-group
Description
Removes wp-g2 from the rest of the components in
ui
except for FontSizePicker, which will be handled in a separate PR.The biggest change here is to use a new context provider to pass
flexItemDisplay
down to FlexItem. This was being done using CSS custom properties before but needed to be redone a different way and context is the only way to do it.How has this been tested?
Unit tests and storybook.
Types of changes
Non-breaking changes.
Checklist:
*.native.js
files for terms that need renaming or removal).