[RNMobile] Add enableCaching param to fetch request on Android

packages/react-native-bridge/android/react-native-bridge/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java

@@ -280,8 +280,9 @@ public void getOtherMediaOptions(ReadableArray filter, final Callback jsCallback
     }
 
     @ReactMethod
-    public void fetchRequest(String path, Promise promise) {
+    public void fetchRequest(String path, boolean enableCaching, Promise promise) {
         mGutenbergBridgeJS2Parent.performRequest(path,
+                enableCaching,
                 promise::resolve,
                 errorBundle -> {
                     WritableMap writableMap = Arguments.makeNativeMap(errorBundle);

packages/react-native-bridge/android/react-native-bridge/src/main/java/org/wordpress/mobile/WPAndroidGlue/RequestExecutor.java

@@ -5,5 +5,5 @@
 import androidx.core.util.Consumer;
 
 public interface RequestExecutor {
-    void performRequest(String path, Consumer<String> onSuccess, Consumer<Bundle> onError);
+    void performRequest(String path, boolean enableCaching, Consumer<String> onSuccess, Consumer<Bundle> onError);
 }

packages/react-native-bridge/android/react-native-bridge/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java

@@ -388,8 +388,8 @@ public void requestMediaPickFrom(String mediaSource,
             }
 
             @Override
-            public void performRequest(String pathFromJS, Consumer<String> onSuccess, Consumer<Bundle> onError) {
-                mRequestExecutor.performRequest(pathFromJS, onSuccess, onError);
+            public void performRequest(String pathFromJS, boolean enableCaching, Consumer<String> onSuccess, Consumer<Bundle> onError) {
+                mRequestExecutor.performRequest(pathFromJS, enableCaching, onSuccess, onError);
             }
 
             @Override

packages/react-native-bridge/index.js

@@ -275,7 +275,10 @@ export function requestMediaEditor( mediaUrl, callback ) {
 	);
 }
 
-export function fetchRequest( path ) {
+export function fetchRequest( path, enableCaching = true ) {
+	if ( isAndroid ) {
+		return RNReactNativeGutenbergBridge.fetchRequest( path, enableCaching );
+	}
 	return RNReactNativeGutenbergBridge.fetchRequest( path );
 }
 

packages/react-native-editor/android/app/src/main/java/com/gutenberg/MainApplication.java

@@ -176,7 +176,7 @@ public void editorDidEmitLog(String message, LogLevel logLevel) {
             }
 
             @Override
-            public void performRequest(String path, Consumer<String> onSuccess, Consumer<Bundle> onError) {}
+            public void performRequest(String path, boolean enableCaching, Consumer<String> onSuccess, Consumer<Bundle> onError) {}
 
             @Override
             public void gutenbergDidRequestUnsupportedBlockFallback(ReplaceUnsupportedBlockCallback replaceUnsupportedBlockCallback,

packages/react-native-editor/src/api-fetch-setup.js

@@ -10,6 +10,9 @@ const SUPPORTED_ENDPOINTS = [
 	/wp\/v2\/search\?.*/i,
 ];
 
+// [ONLY ON ANDROID] The requests made to these endpoints won't be cached.
+const DISABLED_CACHING_ENDPOINTS = [ /wp\/v2\/(blocks)\/?\d*?.*/i ];
+
 const setTimeoutPromise = ( delay ) =>
 	new Promise( ( resolve ) => setTimeout( resolve, delay ) );
 
@@ -18,7 +21,7 @@ const fetchHandler = ( { path }, retries = 20, retryCount = 1 ) => {
 		return Promise.reject( `Unsupported path: ${ path }` );
 	}
 
-	const responsePromise = fetchRequest( path );
+	const responsePromise = fetchRequest( path, shouldEnableCaching( path ) );
 
 	const parseResponse = ( response ) => {
 		if ( typeof response === 'string' ) {
@@ -44,6 +47,9 @@ const fetchHandler = ( { path }, retries = 20, retryCount = 1 ) => {
 export const isPathSupported = ( path ) =>
 	SUPPORTED_ENDPOINTS.some( ( pattern ) => pattern.test( path ) );
 
+export const shouldEnableCaching = ( path ) =>
+	! DISABLED_CACHING_ENDPOINTS.some( ( pattern ) => pattern.test( path ) );
+
 export default () => {
 	apiFetch.setFetchHandler( ( options ) => fetchHandler( options ) );
 };

packages/react-native-editor/src/test/api-fetch-setup.test.js

@@ -1,7 +1,7 @@
 /**
  * Internal dependencies
  */
-import { isPathSupported } from '../api-fetch-setup';
+import { isPathSupported, shouldEnableCaching } from '../api-fetch-setup';
 
 const supportedPaths = [
 	'wp/v2/media/54?context=edit&_locale=user',
@@ -11,12 +11,27 @@ const supportedPaths = [
 	'wp/v2/media?context=edit&_locale=user',
 	'wp/v2/categories/',
 	'wp/v2/blocks/28?_locale=user',
+	'/wp/v2/blocks?per_page=100&context=edit&_locale=user',
 ];
 
 const unsupportedPaths = [
 	'wp/v1/media/', // made up example
 ];
 
+const enabledCachingPaths = [
+	'wp/v2/media/54?context=edit&_locale=user',
+	'wp/v2/media/5?context=edit',
+	'wp/v2/media/54/',
+	'wp/v2/media/',
+	'wp/v2/media?context=edit&_locale=user',
+	'wp/v2/categories/',
+];
+
+const disabledCachingPaths = [
+	'wp/v2/blocks/28?_locale=user',
+	'/wp/v2/blocks?per_page=100&context=edit&_locale=user',
+];
+
 describe( 'isPathSupported', () => {
 	supportedPaths.forEach( ( path ) => {
 		it( `supports ${ path }`, () => {
@@ -30,3 +45,17 @@ describe( 'isPathSupported', () => {
 		} );
 	} );
 } );
+
+describe( 'shouldEnableCaching', () => {
+	enabledCachingPaths.forEach( ( path ) => {
+		it( `enables caching for ${ path }`, () => {
+			expect( shouldEnableCaching( path ) ).toBe( true );
+		} );
+	} );
+
+	disabledCachingPaths.forEach( ( path ) => {
+		it( `does not enable caching for ${ path }`, () => {
+			expect( shouldEnableCaching( path ) ).toBe( false );
+		} );
+	} );
+} );