Docs: Organize and update block theme docs #31167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
|
Size Change: 0 B Total Size: 1.49 MB ℹ️ View Unchanged
|
|
theme-support.md feels a bit left out. If |
|
@carolinan I think you're right, I didn't like that there were two Theme sections and was focused on the Block Theme work. Stepping back it makes sense to make one more encompassing directory and move the block theme work there. It also simplifies changes, I'll update the PR to reflect. |
|
I updated the PR and description to move files together under a unified |
JustinyAhin
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
The changes themselves look fine to me. I've searched across the branch's code if all the links have been replaced, and they are fine as well.
@mkaz I guess you already coordinated with someone from Meta to commit your patch
oandregal
reviewed
Apr 26, 2021
| @@ -1,8 +1,10 @@ | |||
| # Themes & Block Editor: experimental theme.json | |||
| # Global Settings (theme.json) | |||
There was a problem hiding this comment.
I still struggle to communicate theme.json is both for settings & styles. Perhaps naming this "Global Settings & Styles" would help in communicating that?
To clarify: given this doesn't have any effects in URLs, etc. and can be reverted/updated/etc, I'm fine experimenting with anything (this is not a blocker for me).
There was a problem hiding this comment.
I read it as styles is one of the types of Global settings you can set, but not sure if that is too nuanced.
I'm open to suggestions, but do think we should name the file a single thing: "Global Properties" ? 🤷♂️
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A follow up PR to #31065
Updates and organizes the block theme documentation. An overview document was missing from the index, plus naming and consistency around using "block theme"
The previous themes/ directory was removed it contained an extra layer to click through to get to the single theme-support file, plus having two sections about themes is confusing.
how-to-guides/themes/block-theme-overview.mdblock-theme/README.mdtothemes/create-block-theme.mdHow has this been tested?
Documentation update.
You can browse the changes on the branch rendered here.
Types of changes