Writing flow: fix RTL issues #31159
Merged
Writing flow: fix RTL issues #31159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -23 B (0%) Total Size: 1.49 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
fix/rtl-writing-flow-issues
branch
from
ef64b80 to
7cb3e02
Compare
ellatrix
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
ellatrix
force-pushed
the
fix/rtl-writing-flow-issues
branch
from
7cb3e02 to
1672915
Compare
youknowriad
reviewed
Apr 24, 2021
| * | ||
| * @return {boolean} True if rtl, false if ltr. | ||
| */ | ||
| export default function isRTL( element ) { |
There was a problem hiding this comment.
is the existing wp.i18n.isRTL not enough?
There was a problem hiding this comment.
This works in any environment and it's contextual to the element. Different elements may have different directions. Generally, I think it's good to avoid globals.
There was a problem hiding this comment.
We used to have different ways of checking RTL and we consolidate on one recently and I fear this puts us a bit back to more inconsistency.
Now, if the per element logic is something we really need in this use case, I think it's good to have, otherwise I feel we should just consolidate using wp.i18n.isRTL.
There was a problem hiding this comment.
Then perhaps we should revert to not exposing the function but leaving the check by element as it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered in #31138. The current e2e tests are not catching the issue, probably because of timing. It's reproducible manually if you test horizontal arrow navigation between blocks.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).