[RNMobile] Fix notice size overflow #31083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
This was referenced Apr 22, 2021
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
geriux
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3411Description
Related to https://github.com/WordPress/gutenberg/pull/31012/files#r617418413.
Problem
The native version of the notice component doesn't handle properly the size overflow when the text is larger than one line. You can see in the attached screenshots how it looks in the current version.
Solution
I basically updated the styles of this component so the view now fits the text size. Additionally, I set the maximum number of lines for the text to three, this way we prevent that a notice gets too big.
How has this been tested?
For testing this, manual code changes are required to test different text sizes. I tested this by modifying the text of the notice that is triggered when copying a block:
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).