Fix customize widget editor toolbar so that it overlaps preview #31077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
draganescu,
noisysocks,
kevin940726 and
tellthemachines
|
There's a few things that aren't perfect, like this 😄 |
|
Size Change: +108 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
|
Similar to your imperfection I found another one, the scrollbar appears on top of the toolbar in Firefox:
|
draganescu
approved these changes
Apr 22, 2021
I'll make an issue for it. I did look into solving this at the time. A z-index of 41 or higher seems like it'll make the toolbar appear over the top of the scrollbar, but also makes the toolbar appear over everything else. 😄 I had a look to see whether ::-webkit-scrollbar could be used to lower the z-index, but it seems to just make it disappear. Everything looks ok with an always on scrollbar (on windows or when the option is enabled in Mac OS). So I don't think this would be a high priority issue. Update: Actually, it looks like this in Safari: |
|
Perhaps you both already fixed this, but it's working for me:
It does show how it's not the most elegant solution in the world. I think it's a good start because it allows us to make numerous general improvements to blocks in the customizer and how that works, while keeping UI enhancements on a separate track. And that's one thing that @critterverse excellently identified in her comment here: #30720 (comment) — there is an opportunity to elevate the mobile/narrow-viewport interface across the entire block editor, and every improvement made will benefit the editing experience on physical mobile devices as well as constrained contexts. Definitely something to listen to as a separate enhancement opportunity! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30988
Solves the issue where the widgets toolbar is offscreen on desktop.
Requires:
position: fixedcontainer to pull the toolbar out of its normal layerAlso fixes the tab order, so that shift-tabbing from the block goes to the toolbar. The element was in the wrong place in the DOM.
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).