[RNMobile] Handle undefined block case in block actions menu #30920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
@illusaen I saw that you recently introduced changes here related to the transform blocks (related PR), I'd appreciate if you could review these changes because I did some modifications there. |
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
|
@fluiddot This looks good; I don't think it impacts transforms at all 👍 |
fluiddot
commented
Apr 16, 2021
Comment on lines
+292
to
+293
| const selectedBlockClientId = first( getSelectedBlockClientIds() ); | ||
| const selectedBlock = selectedBlockClientId |
There was a problem hiding this comment.
Since the name is singular, I changed these values to be an object instead of array.
fluiddot
commented
Apr 16, 2021
| ? first( getBlocksByClientId( selectedBlockClientId ) ) | ||
| : undefined; | ||
| const selectedBlockPossibleTransformations = selectedBlock | ||
| ? getBlockTransformItems( [ selectedBlock ], rootClientId ) |
There was a problem hiding this comment.
getBlockTransformItems requires to pass an array of blocks.
|
@geriux I added you as a reviewer because I saw you reviewed other PRs related to this part, let me know if it’s ok for you or if I should reference someone else, thanks 🙇 . |
I'll check it out 😃 |
2 tasks
geriux
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3389Description
Problem
I was testing the undo/redo functionality with the debugger enabled and I realised that when undoing a block creation an exception is raised in the blocks actions menu component.
Exception:
TypeError: Cannot read property 'title' of undefinedpackages/block-editor/src/components/block-mobile-toolbar/block-actions-menu.native.js#L275
This exception is not leading to a crash fortunately but it could produce undesired side effects as well as make the debugging experience a bit hard.
I checked further and the cause is that the block can be
undefinedright after the undo action is executed. Some of the calculations made in thewithSelectblock are not checking this case so they produce the TypeError exceptions.Solution
I checked the logic of that part and I added conditions for handling the undefined block case.
How has this been tested?
NOTE: The exception can only be triggered enabling the debugging mode via the RN developer menu.
Sourcestab and enablePause on exception(see attached screenshot)
4. Tap on the initial paragraph block 5. Add some text 6. Duplicate the block 7. Undo the action 8. Observe that a exception is raised pointing to `block-actions-menu.native.js` fileScreenshots
block-actions-menu-exception.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).