Template part - register block variations and area selection inputs from original area definitions. #30821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
changed the title
Addison-Stavlo
added
[Block] Template Part
|
Size Change: +60.9 kB (+4%) Total Size: 1.49 MB
ℹ️ View Unchanged
|
Addison-Stavlo
changed the title
Addison-Stavlo
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as code owners
Addison-Stavlo
requested review from
vindl,
jeyip,
mattwiebe,
david-szabo97,
ntsekouras,
Copons and
creativecoder
|
One thing I've noticed is, wrapper element seems to be defaulting to I inserted a |
ntsekouras
reviewed
Apr 19, 2021
@david-szabo97 good catch! That should be fixed now. |
ntsekouras
approved these changes
Apr 22, 2021
Co-authored-by: Nik Tsekouras <[email protected]>
Addison-Stavlo
deleted the
try/template-part-block-variations-from-filtered-definitions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Template Part block's variations, area selection inputs, and default wrapper elements to be based off the areas defined in template-parts.php and passed into the editor store via settings. This allows these block variations and corresponding selection interfaces throughout the editors to share a single source of truth for the valid areas, their labels, descriptions, etc. Once a new area is defined in template-parts.php (or by the related filter), the corresponding block variation and selection options will automatically be present in the editor.
How has this been tested?
Smoke test the Template parts block variations in the post/page editor and the site editor, verify they continue to work as expected and that the expected wrapper element appears in both the editor and front-end.
Extra Credit Testing:
Add a new area variation and verify it appears and functions as expected throughout the editor. This can either be added directly to the
$default_area_definitionsin template-parts.php, or via thedefault_wp_template_part_areasfilter (for simplicity this can be done in template-parts.php above the correspondingapply_filterscall). Example:Load the editor and verify the new block variation is registered in the inserter and placeholder flow:
That the corresponding icons and description appear for a template part using that variation:
That it appears as an option in the 'area' selection in the block inspector:
That the 'convert to template part' flow from the block toolbar's ellipsis menu (site editor only) contains the new variation as an option:
And that the new template part uses its specified
defaultWrapperElement(both in editor and on front-end) and that it appears as the default in the block inspector selection:Types of changes
Refactor existing functionality for truth consolidation and extensibility.
Checklist:
*.native.jsfiles for terms that need renaming or removal).