-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg Plugin: Format all markdown files using Prettier formatter #30715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
Gutenberg Plugin
Issues or PRs related to Gutenberg Plugin management related efforts
[Type] Code Quality
Issues or PRs that relate to code quality
labels
Apr 12, 2021
gziolo
requested review from
adamsilverstein,
adamziel,
ajitbohra,
cameronvoell,
chrisvanpatten,
dmsnell,
draganescu,
ellatrix,
guarani,
kevin940726,
mmtr,
nerrad,
noahtallen,
noisysocks,
oandregal,
ntwb,
swissspidy,
talldan and
tellthemachines
as code owners
April 12, 2021 06:37
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/prettier-markdown
branch
from
April 13, 2021 08:26
43fd9d5
to
9e9b62f
Compare
gziolo
force-pushed
the
update/prettier-markdown
branch
from
April 13, 2021 08:36
9e9b62f
to
0e7eeec
Compare
I executed |
Let's get this one in before new merge conflicts pop up and track further work in #30795. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Gutenberg Plugin
Issues or PRs related to Gutenberg Plugin management related efforts
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #30240 where @ockham proposed we start formatting more types of files, other than JS files.
It's a result of executing:
npx prettier --format **/*.md
Let's see how it plays out in practice with CI checks.
Known issues
It doesn't play nicely with
npm run docs:build
. @nosolosw, is it possible to include formatting in the process of generating automated docs with@wordpress/docgen
or is better to run code formatting as the post-processing step inside the shell script we use?