Gutenberg Plugin: Format all JSON files using Prettier formatter #30714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz,
mmtr,
nerrad,
oandregal,
ntwb and
swissspidy
as code owners
gziolo
force-pushed
the
update/prettier-json-files
branch
from
e6ea5f8 to
d73ff1a
Compare
gziolo
added
[Type] Code Quality
gziolo
changed the title
|
Size Change: +857 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
😲 |
mkaz
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Quite a few files to review 😆
It looks like most of the fixes are changes to the test fixtures and range parameters,, so those passing will be a good confirmation. Will the auto generated fixtures need to be updated?
I updated the manifest tool to include a new line when it generates, this clears up that error.
aristath
approved these changes
Apr 13, 2021
Good observation. It's hard to tell, but as long as we don't run checks on the formatting it's acceptable. I wanted to split efforts into smaller steps as much as possible. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #30240 where @ockham proposed we start formatting more types of files, other than JS files.
It's a result of executing:
npx prettier --format **/*.jsonLet's see how it plays out in practice with CI checks.
Known issue
See https://github.com/WordPress/gutenberg/pull/30714/checks?check_run_id=2321165368#step:9:6
docs/manifest.jsonfile gets a different end of file when generated withnpm run docs:build