deprecated: Export DeprecatedOptions to align with DefinitelyTyped #30677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
fix/types-deprecated-align-with-dt
branch
from
b9e840b to
db2f9e6
Compare
noahtallen
approved these changes
Apr 9, 2021
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the deprecated package where the types do not align with the
DefinitelyTypedexported types. This could cause a regression in type usage if someone was depending on theDeprecatedOptionsexport fromDefinitelyTypedand then upgraded to the most recentdeprecatedpackage which declares its own types. This fixes that.Similar to #30570
How has this been tested?
Only changes to type annotations so as long as the type check passes we're good.
Types of changes
Bug fix for DefinitelyTyped.
After this is merged and released we can run the
not-neededscript on DefinitelyTyped to delete the deprecated package from there.Checklist:
*.native.jsfiles for terms that need renaming or removal).