RichText: add onBlur prop to so onBlur callback from block-editor can be plumbed through #30587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or can be plumbed through
glendaviesnz
added
[Type] Enhancement
glendaviesnz
requested review from
cameronvoell,
ellatrix and
guarani
as code owners
7 tasks
|
Size Change: +7 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Thanks for looking into this @glendaviesnz ! I applied the latest patch from #30407 to this branch. The image caption blurs as expected:
I added a Once this goes through we could add a handler to the gallery caption field as well 🎉 |
ramonjd
added a commit
to ramonjd/gutenberg
that referenced
this pull request
Apr 8, 2021
…ur from the caption field. To do this we add an onBlur event to the RichText block based on the work so far in WordPress#30587, which fires an onBlur handler passed as a prop.
2 tasks
|
@ellatrix did you have any thoughts on this? do you know if there was a reason why the onBlur prop was not plumbed through from the |
|
I'm not sure if we can simply use onBlur to set selection state. What if focus moves to the toolbar? |
Good point, will take another look at it with that in mind. |
|
Closing or now. As @ellatrix pointed out it is not possible to know if the blur was caused by a click on the richtext toolbar. |
|
@glendaviesnz Btw, I'm refactoring rich text and in a few more PRs, I'll make it possible to use |
This was referenced May 11, 2021
|
@glendaviesnz Actually, I don't think we even need it. I removed all caption focus handling from the image and gallery block in #31796 and absorbed it into the block editor with a one liner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The block-editor RichText wrapper has an onBlur prop available, but this is ignored by the underlying RichText package, so there is no way to pass through an onBlur callback from blocks that make use of RichText.
This prevents easy handling of the isSelected state to do the likes of removing the formatting toolbar when the control is blurred, eg. #30334
How has this been tested?
Has been tested manually against #30407
Types of changes
Plumbs through an optional onBlur prop which is called on component blur event
Checklist: