Navigation editor - fix for manage theme locations data lost when menu is deselected #30440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzim
added
[Type] Bug
grzim
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +59 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
getdave
requested changes
May 18, 2021
There was a problem hiding this comment.
Screen.Capture.on.2021-05-18.at.08-27-10.mov
Tested and this wasn't working for me 😞 It does look like the PR needs a rebase though.
The main issues I"m seeing:
- console errors when toggling the menu locations (see video).
- menu location checkbox doesn't toggle after the initial interaction.
@grzim Is it likely you will be able to help move this forward or would you prefer someone to take it over?
|
Moving back to "Needs dev" as no movement here. |
|
Closing this one. It can serve as a basis for future work as required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #30424
When the menu was deselected and then selected again, theme management data was lost. In order to fix this behavior I have moved the useMenuLocations hook to layout
How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).