Packages: Add types directive to api-fetch and date packages #30252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Mar 25, 2021
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| - Bundle type definitions. | |||
There was a problem hiding this comment.
It could have a section like:
### New FeaturesThe same applies to the api-fetch package.
sarayourfriend
force-pushed
the
add/types-directive-packagejson
branch
from
1f67e61 to
ee9b4d5
Compare
gziolo
pushed a commit
that referenced
this pull request
Mar 26, 2021
* Add types directive to packages that need it * Update date CHANGELOG for types * Fix changelogs
gziolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that
dateandapi-fetchare fully typed, we can add thetypesdirective to theirpackage.jsonfiles.How has this been tested?
Build passes
Types of changes
Non breaking changes.
Checklist: