Fix adding blocks in the widgets customizer #30221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: +1.89 kB (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
I tested this and it's almost perfect. The problem I found was that adding blocks by pressing enter made the content of the starting block disappear from the preview. customizer-upating.mp4 |
noisysocks
reviewed
Mar 25, 2021
packages/customize-widgets/src/components/sidebar-block-editor/use-sidebar-block-editor.js
Outdated
Show resolved
Hide resolved
|
@draganescu That's seems a little bit tricky, and I suspect that it's happening in the widgets editor too. I created a separate issue to track it: #30268. |
13 tasks
draganescu
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
This works amazingly well, and along with @noisysocks 's suggested update the code is great as well. I'll merge it.
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix adding blocks in the widgets customizer. Part of #29284.
How has this been tested?
Screenshots
Kapture.2021-03-25.at.15.20.06.mp4
Types of changes
Bug fix
Checklist: