Navigation Block: De-emphasize "Link" block. #30172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
|
Size Change: +5 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Mar 24, 2021
|
Thank you for the review! Turns out there was a legitimate test failure, and in trying to fix it (see 8f8b436), I touched code that @gwwar tinkered with just a few weeks ago. Because that specific test was sensitive, I've converted this PR to a draft until she has a chance to look and see if I fixed it right. |
|
🤔 The current link search allows us to insert all types if we search for it (post, page, category, etc), did we want to limit it to an arbitrary title/url combo?
eg Let me know if you run into trouble with this. |
annezazu
reviewed
Mar 24, 2021
Thanks for that clarification! Maybe? #30170 was created to outline some of the confusion around the different types of blocks you can insert, and the fact that it all sort of blends together is part of the problem. However in absence of more obvious transformation tools, it's probably not a good time to make such a change. But it might be in the future. Thanks a bunch for the test pointeres. I've udpated! |
|
Welp, I commented on the wrong PR. I meant to comment on #30047 |
jasmussen
force-pushed
the
try/de-emphasize-link-block
branch
from
1caf827 to
3d02a4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One thing recent rounds of FSE testing has surfaced, is that when you create a navigation menu and start empty, people seem to very commonly be choosing the "Link" block to insert their navigation links, when in nearly all cases the "Page Link" block would've been a better choice, actually suggesting pages on your site to link to.
This PR renames "Link" to "Custom Link", to de-emphasize it. Before:
After:
Checklist: