[Mobile] Removes Preview editor mode #29896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
antonis
force-pushed
the
rnmobile/3217-removePreview
branch
from
243e8f8 to
3cc64c0
Compare
This was referenced Mar 16, 2021
|
Leaving this in draft state till we test that nothing breaks on both platforms |
3 tasks
|
I think we can also remove these: gutenberg/packages/react-native-bridge/ios/GutenbergBridgeDelegate.swift Lines 134 to 136 in 3cc64c0 |
antonis
force-pushed
the
rnmobile/3217-removePreview
branch
from
3cc64c0 to
971694d
Compare
This was referenced Mar 24, 2021
|
Hi Antonis! 👋 😄 I've reviewed and tested this, and everything is working as expected (I found no regressions). The code changes look good. I also began the same removal on the iOS side (WordPress-iOS) and explored a bit further. I think we can remove a few more things, since after removing the template preview event logging code, the only remaining part is the template apply. I investigated that, and I believe it is also ripe for removal. This also allows us to also remove the interface methods that are only in being utilized for this purpose, as well as a few switch cases. Since these changes are a bit larger, I decided not to push them directly, in case you had some thoughts about it, so instead I've opened some PRs with these respective PRs as a base (the WordPress-iOS PR is the only one I opened that targets |
|
Hey @mkevins 👋 Thank you for stepping forward and helping with the code cleanup 🙇
I reviewed and merged the PRs that targeted my branches. I also reviews the IOS PR and everything looks good 🎉 |
chipsnyder
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after wordpress-mobile/gutenberg-mobile#2980 is complete on both platforms
Fixes wordpress-mobile/gutenberg-mobile#3217
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3268WordPress-AndroidPR: wordpress-mobile/WordPress-Android#14270WordPress-iOSPR: wordpress-mobile/WordPress-iOS#16155Description
This PR removes the editor preview mode introduced for the layout picker preview functionality that is being replaced with a webview implementation.
The changes introduced with the following PRs should are reverted
Note that the refactoring introduced with #27640 has been considered
How has this been tested?
Quick sanity of the editor to validate that no functionality is unintentionally broken
You can use the build from wordpress-mobile/WordPress-Android#14270
Types of changes
Code cleanup
Checklist: