useMergeRefs: call when dependency changes after ref change #29892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Size Change: +4 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Mar 16, 2021
|
Thanks @ellatrix! |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28166.
Fixes a bug in
useMergeRefs. If a ref changes,didElementChangeis set totrueto prevent refs to be called twice (once on the ref change and once on the dependency change that is triggering the ref change). This flag should be reset on every render, so when dependencies change the next time, the ref calling is not skipped.How has this been tested?
Screenshots
Types of changes
Checklist: