-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e tests for navigation menu name editor #29774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
grzim
commented
Mar 15, 2021
talldan
added
[Feature] Navigation Screen
[Type] Task
Issues or PRs that have been broken down into an individual action to take
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
labels
Mar 17, 2021
grzim
requested review from
adamziel,
ajitbohra,
draganescu,
kevin940726,
nerrad,
noisysocks,
ntwb,
talldan and
tellthemachines
as code owners
March 20, 2021 16:28
talldan
reviewed
Mar 22, 2021
grzim
force-pushed
the
e2e/navigation-menu-name-editor
branch
from
March 24, 2021 22:01
5d47c6c
to
3e81a1c
Compare
talldan
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
grzim
force-pushed
the
e2e/navigation-menu-name-editor
branch
from
March 25, 2021 11:28
517e5ca
to
abf9b3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
[Type] Task
Issues or PRs that have been broken down into an individual action to take
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
End to end tests for the feature to change selected menu name in navigation menu editor
How has this been tested?
Run end to end tests suite (
npm run test-e2e
)Screenshots
Types of changes
End to end tests for recently added feature
Checklist: