Skip CSS minification via PHP #29624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Type] Enhancement
6 tasks
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please see discussion on #28358 (review) for details.
Since
npm run buildproduces minified files we don't need the modification function.This PR removes it and all related code. This is a server-side performance improvement, and also removes a complicated PHP regex. The simplification is more robust and a lot cleaner.
cc @youknowriad
How has this been tested?
Tested by running an FSE theme and making sure there are no errors.
Types of changes
gutenberg_get_minified_stylesfunction and all references to itChecklist: