Add navigation editor block deselection when clicking canvas background #28876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
adamziel,
ajitbohra,
draganescu,
kevin940726,
nerrad,
noisysocks,
ntwb and
tellthemachines
as code owners
talldan
changed the title
talldan
added
[Type] Regression
|
Size Change: +161 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
talldan
force-pushed
the
add/navigation-editor-block-deselection
branch
from
316f1fe to
a09c34a
Compare
shaunandrews
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
I can't get used to the emptiness of the completely deselected state. Couldn't we instead have the nav block selected by default? This screen has no other function so it seems weird to have to select the nav block in order to interact with it.
The other thing is there's still a blue outline around the block after it's deselected:
|
@tellthemachines Yeah, I've suggested that as well in previous iterations. I'm open to trying that, but maybe in a separate PR. I couldn't reproduce the issue with the blue border: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reimplements #28382, which had regressed (been accidentally removed).
How has this been tested?
e2e tests were already written and have been renabled
Manual testing:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: