-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move fetch-link-suggestions to a separate file and refactor it #28843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of all state mutatations and impure operations
Size Change: +133 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
6 tasks
grzim
added
[Type] Enhancement
A suggestion for improvement.
[Package] Edit Navigation
labels
Feb 17, 2021
closing this PR, as refactor of the file is not esential |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move fetch-link-suggestions to a separate file and refactor it to get rid of all state mutations and impure operations
Description
This PR was made in order to simplify
packages/edit-navigation/src/index.js
and move fetchLinkSuggestion function to an external file. The function has been refactored to make it a linear, functional data flow.How has this been tested?
Local tests passed (npm run test).
Tested manually.
Types of changes
Refactor
Checklist: