Site Editor: Expose edit-site store #28722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +168 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
david-szabo97
force-pushed
the
try/edit-site-store-without-initialize-function
branch
from
54e36bf to
938d27e
Compare
gziolo
added
[Package] Edit Site
david-szabo97
requested review from
vindl,
jeyip,
mattwiebe,
Addison-Stavlo,
Copons and
gziolo
gziolo
reviewed
Feb 4, 2021
| @@ -48,7 +48,7 @@ const interfaceLabels = { | |||
| drawer: __( 'Navigation Sidebar' ), | |||
| }; | |||
|
|
|||
| function Editor() { | |||
| function Editor( { initialSettings } ) { | |||
There was a problem hiding this comment.
I would appreciate a sanity check from someone familiar with the edit site's editor initialization.
ntsekouras
reviewed
Feb 4, 2021
ntsekouras
reviewed
Feb 4, 2021
Copons
approved these changes
Feb 5, 2021
david-szabo97
deleted the
try/edit-site-store-without-initialize-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Gutenberg all the stores are exposed from the
storefile, except a few likecore/edit-site. This PR aims to refactorcore/edit-sitestore to work the same way as other stores.Rather than preloading the settings into the
store, we are passing the initial state to the editor which takes care of updating the settings in the store.This change allows us to use the
storeobject properly together withselectetc. (No more hacky global variable)How has this been tested?
Make sure tests are passing, CI passing, and smoke test!
Screenshots
Types of changes
Code quality
Checklist: