Site Editor: Replace core/edit-site store name with store object #28695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
[Type] Code Quality
david-szabo97
requested review from
mattwiebe,
gziolo,
vindl,
Copons,
jeyip and
Addison-Stavlo
17 tasks
|
Size Change: +1.21 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
rafaelgallani
requested changes
Feb 3, 2021
gziolo
reviewed
Feb 4, 2021
| @@ -12,15 +12,24 @@ import * as actions from './actions'; | |||
| import * as selectors from './selectors'; | |||
| import { STORE_NAME } from './constants'; | |||
|
|
|||
| export let store = null; | |||
|
|
|||
| export default function registerEditSiteStore( initialState ) { | |||
There was a problem hiding this comment.
It's out of the scope of this PR, but the way this store is initialized is a bit concerning. It could be null, but I guess it was also the case before. I'm curious why the initial state has to be set explicitly rather than dispatched with an action.
registerEditSiteStore calls wouldn't be necessary in the tests otherwise.
There was a problem hiding this comment.
I don't know the reason for that either 🤔 I'll ask around and experiment so we can create a follow-up PR to clean it up.
|
Thank you for this refactoring 💯 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #27088
Replaces hardcoded strings with the store object.
Store object wasn't exposed before due to the nature of how it's initialized. The current solution feels a bit hacky so looking forward to suggestions.
How has this been tested?
Types of changes
Code Quality
Checklist: