Fix insertUsage persistence in block-editor store #28694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
ockham,
mcsf,
youknowriad,
noisysocks and
gziolo
6 tasks
|
Size Change: +57 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
gziolo
added
Backport to WP 6.7 Beta/RC
gziolo
approved these changes
Feb 4, 2021
noisysocks
pushed a commit
that referenced
this pull request
Feb 7, 2021
noisysocks
pushed a commit
that referenced
this pull request
Feb 8, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Somewhere down the road the
insertUsagepreferences stoped working properly. This setting is being taken into account for the ordering of blocks in any block Inserter.This is related to moving the specific option from
core/editorstore tocore/block-editorstore - although that happened a while ago. There is a bug that overrides theblock-editorinsertUsagepreferences with theeditor's ones, which default to empty object.This PR fixes that by merging
insertUsagefrom both stores, giving priority to the currently used store (block-editor).Testing instructions
Most used blocksor any inserter.