[WIP] Border Radius Support: Allow zero, min and max border radius values #28541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs access to Global Styles border radius value to better set the control value when its reset button is pressed. Current workaround for demo purposes is adding a default value to the theme.json settings.
aaronrobertshaw
added
[Type] Bug
|
Size Change: +59 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
This PR is testing well for me manually, and the
I see what you mean. In gutenberg/lib/global-styles.php Line 246 in b0d4e1f Alternately, Is it possible to try to use the |
|
Thanks for taking a look at this one!
I did try using the The more styles added via block support and configurable via global styles the more reason I see to have this available in the core block editor. Being able to handle the default values correctly certainly reduces unexpected behaviour in the UI for users. |
I might be misremembering this but I think those were actual CSS styles so not exactly easy to extract the theme.json set value from. |
7 tasks
|
Closing this trial PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues with this approach
defaultRadiusvalue to the theme.json settings for the block context. Assuming that matches the style value, then the reset would appear to work correctly.How has this been tested?
Manually.
Testing instructions
0value border radius and it takes affect.Screenshots
Types of changes
Bug fix.
Checklist: