Fix URL cutoff. #28515
Merged
Fix URL cutoff. #28515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +53 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Just noting I can't replicate the same exact issue as before but still am so excited for this improvement after doing a quick test of what's currently in place! |
jasmussen
force-pushed
the
try/fix-url-cutoff
branch
from
916b72e to
d85b30b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22298.
The original issue that @annezazu reported I can no longer reproduce. It seems likely that the issue experienced was related to CSS bleed from the theme itself, an issue that has potentially been fixed by the URL popover moving outside the editing canvas. I tested in all the twenties and could not reproduce the initial issue.
However there were improvements to be made, still. The 230px max-width doesn't appear necessary, as the container is a flex container and should size the input field
Before:
After: