Fix margins and width of 100%-width buttons #28467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Nice. Let's try it, and put a note in the theme update notes. |
|
LGTM |
|
Thanks, everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a button is set to 100% width, it isn't quite 100% width. It also incorporates space for a right margin:
This gets especially weird when the buttons in there are justified to the center, and he right margin on the last item is automatically removed:
Since 100%-width buttons won't ever have anything to the right of them, I think it's fine for them to lose that margin all the time and actually be 100% width. This PR makes that change: