Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Mover wording: 'Move block position' to 'Change block position' #28454

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Block Mover wording: 'Move block position' to 'Change block position' #28454

merged 1 commit into from
Jan 25, 2021

Conversation

illusaen
Copy link
Contributor

Description

Changing 'Move block position' to 'Change block position' for block mover as per Slack chat with Wordpress.org folks, cc: @hypest, @iamthomasbishop.

How has this been tested?

  1. Insert paragraph block and type text.
  2. Insert heading block.
  3. Long press up block mover.
  4. Confirm that title on popped up action sheet says 'Change block position'.

Screenshots

iOS Android

Types of changes

Grammatical bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@iamthomasbishop
Copy link

@illusaen Sounds good to me! 👍

@illusaen illusaen marked this pull request as ready for review January 25, 2021 21:42
@illusaen illusaen requested a review from ellatrix as a code owner January 25, 2021 21:42
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected. Thanks @illusaen ! 🙇

@mchowning mchowning merged commit df45403 into WordPress:master Jan 25, 2021
@github-actions github-actions bot added this to the Gutenberg 9.9 milestone Jan 25, 2021
@illusaen illusaen deleted the change_grammar_for_block_mover branch January 25, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants