Identify template parts in error messages #28398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the template part slug to the error messages helps developers identify the missing template part.
carolinan
added
the
Good First Review
gziolo
added
the
Internationalization (i18n)
aristath
requested changes
Mar 4, 2021
Co-authored-by: Ari Stathopoulos <[email protected]>
Co-authored-by: Ari Stathopoulos <[email protected]>
Remove the icons that were left after solving the merge conflict.
carolinan
commented
Mar 23, 2021
| @@ -65,8 +65,12 @@ function render_block_core_template_part( $attributes ) { | |||
| } | |||
| } | |||
|
|
|||
| if ( ! $template_part_id || is_null( $content ) ) { | |||
| return __( 'Template Part not found.' ); | |||
| if ( is_null( $content ) && is_user_logged_in() ) { | |||
There was a problem hiding this comment.
Should this check for a user role and not only logged in users?
There was a problem hiding this comment.
I was thinking about that too... Maybe current_user_can( edit_themes ); 🤔
There was a problem hiding this comment.
Perhaps leave it as is until #27597
There was a problem hiding this comment.
^ That's why I approved the PR 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28056
This PR adds the template part slug to the error messages when a template part can not be found.
The error message on the front is only visible to logged in users and is now translatable.
How has this been tested?
To confirm the issue in #28056 you first need a full site editing theme where a template part is missing.
You can install TT1 Blocks and rename either the header or footer template part files inside
the block-template-parts folder, and view the site editor and the front.
In the site editor, you should see the message: Template part has been deleted or is unavailable.
On the front, you should see: Template Part Not Found.
If you log out, you should see that the error message is visible to all visitors.
Apply the PR.
View the front while logged out. The error message should not be visible.
Login. The error message should now say: Template part has been deleted or is unavailable: (template part slug)
Open the site editor. The error message should now say: Template part has been deleted or is unavailable: (template part slug)
Screenshots
Types of changes
Enhancement, bug fix.
Checklist: