Site Editor: Add unit test for site templates export #28323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
[Type] Automated Testing
david-szabo97
requested review from
mattwiebe,
vindl,
Copons,
jeyip,
noahtallen and
Addison-Stavlo
david-szabo97
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
Addison-Stavlo
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
✅ - Zip file is still created/downloaded.
✅ php tests are passing.
test looks good to me! I don't have too much experience with exporting, I notice @youknowriad has dome some with this previously so maybe he has an idea of anything else that may make sense to be checked here.
mattwiebe
approved these changes
Jan 19, 2021
jeyip
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Testing
Tested with tt1 blocks
Behavior
- Exports a zip file that contains all block templates and block template parts for the site
- PHP unit tests pass locally
- PHP units tests pass in Circle
Browsers
- Chrome
- Firefox
- Safari
- Edge
- IE11
Didn't test IE11 because of an existing issue #28249
vindl
approved these changes
Jan 23, 2021
vindl
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a simple unit test to make sure the export function works.
How has this been tested?
Make sure export still works
Make sure tests are passing
npm run test-unit-phpTypes of changes
Code Quality
Checklist: