Site Editor: Fix _wp_file_based term deletion in migration #28300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Bug
|
Size Change: +1.2 kB (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
Worked for me. Is there any chance that |
youknowriad
reviewed
Jan 19, 2021
| @@ -49,14 +49,17 @@ function _gutenberg_migrate_remove_fse_drafts() { | |||
| } | |||
|
|
|||
| // Delete _wp_file_based term. | |||
| $term = get_term_by( 'name', '_wp_file_based', 'wp-theme' ); | |||
| $term = get_term_by( 'name', '_wp_file_based', 'wp_theme' ); | |||
youknowriad
approved these changes
Jan 19, 2021
Thanks for testing!
I like the idea -- it also would make it less easy to confuse the option with the eponymous code constant. @youknowriad Would you be okay with that? |
Makes sense, but we should keep the const as is. |
ockham
added a commit
that referenced
this pull request
Jan 19, 2021
* Hook into `init` instead of `plugins_loaded`. * Fix typo in taxonomy (`wp-theme` -> `wp_theme`). * Rename option to `gutenberg_version_migration` to conform with usual convention, and to distinguish from `_GUTENBERG_VERSION_MIGRATION` constant.
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purports to fix #28155 🤞
The reason for this is twofold:
plugins_loaded. However, thewp_themetaxonomy was only registered uponinit(see Database migration didn't work properly #28155 (comment)).wp-theme(dash) rather than thewp_theme(underscore) taxonomy (see Database migration didn't work properly #28155 (comment)).How has this been tested?
Make sure you have a
_wp_file_basedterm (in thewp_themetaxonomy) lying around from a run of the Site Editor prior to GB 9.8. To verify that you do have one, run(If this comes back empty, downgrade your version of Gutenberg to 9.7 (e.g.
git checkout release/9.7 && npm run build), install and activate an FSE-enabled theme, and load the Site Editor. Run the above WP CLI command again to verify that it worked.)Assuming that that object is present:
_GUTENBERG_VERSION_MIGRATIONoption in order to have the migration triggered:npm run wp-env run cli "wp option delete _GUTENBERG_VERSION_MIGRATION"inithook, and thus, the migration.)_wp_file_basedterm is gone by once again running:Types of changes
Bug fix
cc/ @carlomanf for review 🙂