Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Release v1.44.1 #28203

Merged
merged 15 commits into from
Jan 18, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mobile - Link settings - Fix data not being saved when closing the bo…
…ttom sheet (#27997)
  • Loading branch information
Gerardo Pacheco authored and guarani committed Jan 5, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit fce8e498c779c50ee74447d84f7ad3e3688e25a8
Original file line number Diff line number Diff line change
@@ -89,7 +89,7 @@ function LinkSettings( {

const { onHandleClosingBottomSheet } = useContext( BottomSheetContext );
useEffect( () => {
if ( ! onLinkCellPressed ) {
if ( onHandleClosingBottomSheet ) {
onHandleClosingBottomSheet( onCloseSettingsSheet );
}
}, [ urlInputValue, labelInputValue, linkRelInputValue ] );