Annotations: Replace store name string with exposed store definition #28156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -309 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Jan 13, 2021
| 'core/annotations', | ||
| addAnnotationClassName | ||
| ); | ||
| addFilter( 'editor.BlockListBlock', STORE_NAME, addAnnotationClassName ); |
There was a problem hiding this comment.
This one is probably incidentally the same. It should remain hardcoded since it need to always remain the same fir backward compatibility.
There was a problem hiding this comment.
Sorry for taking so long to answer. Shouldn't it be ok, as the change was using the store name (constant) instead of the definition?
There was a problem hiding this comment.
I fixed it, conceptually those are 2 different things.
There was a problem hiding this comment.
You mean that this core/annotations reference shouldn't be replaced since it's not related to the store definition?
If that's the case, then I'm sorry. I didn't go further on the function to check whether it was related or not, just replaced it. Sorry :(
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #27088. Replaces the store names (hardcoded strings) with the exposed
storedefinitions.There's still (only) one hardcoded reference to the store name left:
e2e-tests/plugins/plugins-api/annotations-sidebar.js, but since it's a E2E test file, it's best to leave it there, as explained in #27414 (comment).How has this been tested?
npm run test.Types of changes
Code refactoring, non-breaking change.
Checklist: