Add panel button props #28147
Merged
Add panel button props #28147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.99 kB (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jan 15, 2021
There was a problem hiding this comment.
Hey @joshuatf - thanks for working on this.
What is the reason for wanting this? Because your example is about disabled which isn't so common I think. For example I think we wouldn't render a Panel at all instead of disabling it.
Having said that, if there are use cases, I think we shouldn't name it buttonProps and at the end of destructure in PanelBody we should gather all the rest properties like this: ...props and then pass them on to PanelBodyTitle that applies them in the Button.
|
Thanks for the review @ntsekouras. We’re using these props in the linked PR above ( woocommerce/woocommerce-admin#5970 ) to disable a toggle that has no content. This is both an accessibility issue and UI issue for us. I can't speak to how common this is, but preventing an empty panel from being toggled is better in our case than simply removing the panel body. I can see other use cases for this as well, such as passing custom I’m not sure renaming this to |
|
Hey @joshuatf - we can go with |
|
Good call @ntsekouras, added in f807042. |
lipemat
added a commit
to lipemat/types-js-boilerplate
that referenced
this pull request
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
buttonPropstoPanelBodyto allow modifying the button state/props for panel toggles.How has this been tested?
Verified manually via storybook and added tests for addition of props.
npm run storybook:devScreenshots
Checklist: