Fix block error when transforming blocks with Link Popover opened #28136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Jan 12, 2021
| @@ -31,8 +31,10 @@ export function useAnchorRef( { ref, value, settings = {} } ) { | |||
| const activeFormat = name ? getActiveFormat( value, name ) : undefined; | |||
|
|
|||
| return useMemo( () => { | |||
| const { ownerDocument } = ref.current; | |||
| const { defaultView } = ownerDocument; | |||
| if ( ! ref.current ) return; | |||
There was a problem hiding this comment.
When is this null? On first render?
There was a problem hiding this comment.
Seems like rewriting as a callback ref would fix it, this is typically the kind of bugs passing "ref" to hooks can create.
There was a problem hiding this comment.
(just a small remark, not necessarily for now)
There was a problem hiding this comment.
No. It's undefined when clicking the transform item.
ntsekouras
deleted the
try/conversion-of-block-with-link-popover-opened
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #28111
To reproduce
I'm not sure if there is a better fix here, but I'd love any ideas if you have any...
The change in code come from this PR: #26782