Prevent link paste in RichText components in Button and Navigation blocks #28130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
commented
Jan 12, 2021
|
Size Change: +19 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
Thanks for the ping Riad! @lukewalczak , seems like this PR touched code you were involved with so, can you give this a look to verify that things are still OK for native mobile? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28091
I noticed that "pasting behavior" don't take into consideration the
withoutInteractiveFormattingor theallowedFormatsprop. This PR refactors the RichText component a bit to move all the filtering logic to the useFormatTypes hook making sure the "formatTypes" available in the RichText component are consistent in all interactions.Noting that I had to do a change in mobile code too to accommodate this.
Testing instructions