-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Block: Allow using locally installed packages with templates #28105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Tool] Create Block
/packages/create-block
[Type] Enhancement
A suggestion for improvement.
[Type] New API
New API to be used by plugin developers or package users.
and removed
[Tool] Create Block
/packages/create-block
[Type] Enhancement
A suggestion for improvement.
labels
Jan 11, 2021
6 tasks
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/create-block-local-package
branch
from
January 12, 2021 07:11
cec3d69
to
81d9254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Tool] Create Block
/packages/create-block
[Type] New API
New API to be used by plugin developers or package users.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: #27881.
This PR will simplify testing of the new template that @jessynd is baking in #27881. So far it was possible to use only built-in templates (
es5
andesnext
) and 3rd party templates hosted on npm. There is a proposal to add a new template to be used with the Create a Block Tutorial. It's going to be published to npm as an official WordPress package, but as usual we want to make it testable with the latest version during development. This is where testing with locally installed packages is going to be helpful.How has this been tested?
I did a couple of tests mostly to validate existing functionality.
Built-in template
Works as usual.
Installed packages
Testing errors for now.
External packages
Types of changes
Checklist: