Testing: Prevent a direct usage of Reakit #28095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Status] Blocked
8 tasks
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
gziolo
changed the title
gziolo
force-pushed
the
update/lint-reakit-usage
branch
from
1c334db to
76e7f35
Compare
gziolo
removed
the
[Status] Blocked
youknowriad
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up for #28085.
This PR ensures that
reakitimports won't be possible unless explicitly allowed inside `@wordpress/components. It should help prevent bundled code duplication as observed in #28085 that reduces the build size by 20 kb for a few API methods used.How has this been tested?
npm run lint-js -- -quietAt the moment it reports 4 errors. They should get resolved once #28085 is merged.