Build Plugin Workflow: Bump node version to 14 #28048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All other workflows (i.e. GH actions) were updated to Node 14 by #26835. At that time, the Build Plugin workflow was still under development, so it was merged when still using node 12.
How has this been tested?
Verify that the 'Build Gutenberg Plugin Zip' action at the bottom of this PR still works. Click on it to inspect it, and to verify that it has a working
gutenberg.zipplugin artifact attached.For bonus points,
grep(or use your editor search) to verify that there are no other instances ofnode-version: 12in the project.