Performance tests: Fix #28026
Merged
Performance tests: Fix #28026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
It looks like the issue is with the lock file in one of the older branches. In general, all those development dependencies should be hoisted to the root Example:
one of the React Native packages overrides packages on purpose and therefore they are installed as local dependencies.
|
youknowriad
approved these changes
Jan 7, 2021
If it helps then sure, but I'm afraid it's a fix that will work only one time 😄 |
|
it seems as written it doesn't work anyway because distclean command is not available in old branches, we should just move the command to the command instead. @gziolo what do you mean it works only one time. |
|
In general, we tend to avoid having different versions of the same development packages (in fact all of them, see |
Hmm right, makes sense. It's a bit confusing to keep track of which files are used from the current branch, and which ones from the ones that are being evaluated 😅 Anyway, I'll change accordingly. |
ockham
force-pushed
the
fix/performance-tests
branch
from
0cb43e5 to
ca61b4a
Compare
Done (and rebased). |
|
Going to merge (per Riad's approval here, and having applied this change) 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purports to fix an issue that @youknowriad shared via Slack:
Specifically, the module that can't be found is
levenary(which is required by babel).I was able to reproduce by following those steps manually. It seems like the problem is with nested
node_modules/directories, e.g.packages/babel-preset-default/node_modules/. Consequently, this PR adds a newdistcleancommand topackage.jsonto also remove those nestednode_modules/, and uses that command in the perf test script.How has this been tested?
It hasn't really -- I'm having trouble running the perf tests on my Linux box 😬
The command to test them is
Types of changes
Bug fix