Compose: Export useIsomorphicLayoutEffect and use it #28023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.29 kB (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
13 tasks
ItsJonQ
approved these changes
Jan 6, 2021
gziolo
reviewed
Jan 7, 2021
gziolo
added
[Package] Compose
gziolo
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of #28020. It exports the already existing
useIsomorphicLayoutEffecthook from thecomposepackage and then updates various places that duplicated this code to use the exported function fromcompose. We're doing this because it is a dependency of thecontextpackage from G2.How has this been tested?
Manually tested in components and Gutenberg in the places where it is used.
AnglePickerControlandGradientPickerin storybookuseSelectanduseDispatchby just using Gutenberg for a little bit to create and edit a postTypes of changes
New feature
Checklist: