-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout: Add metabox placeholder shell #2800
Conversation
Safari has default margins and resets color in active state
Previously there was a 1px gap, presumably specifically targetting the sidebar to allow focus outline to show on all sides, but this was problematic because (a) focus glow isn't 1px in most browsers and (b) this should be shown by allowing overflow ideally and (c) if necessary, should target only cases where it's required (sidebar)
Codecov Report
@@ Coverage Diff @@
## master #2800 +/- ##
==========================================
- Coverage 33.82% 33.73% -0.09%
==========================================
Files 189 190 +1
Lines 5661 5676 +15
Branches 988 991 +3
==========================================
Hits 1915 1915
- Misses 3171 3183 +12
- Partials 575 578 +3
Continue to review full report at Codecov.
|
🚢 it |
💥 |
Not sure if this is the right place to comment. And apologies if this is all covered elsewhere, but I wanted to give some feedback on seeing this: a) Meta boxes currently have several places that they can live: in the sidebar, below post content with different priorities and contexts |
+1 for everything @rosswintle is saying. I'll add that plenty of interfaces have required meta fields which almost certainly shouldn't be kept in a collapsed-by-default area. |
@rosswintle @mrwweb These concerns are legitimate and have already been raised in #952 For the first iteration, we'll probably keep the collapsed state but have multiple areas. Feel free to discuss this more in the metaboxes issue |
Closes #2760
Closes #2322
Related: #2583
While development of metaboxes continues in #2583, this pull request seeks to add a static content shell for representing the container in which meta fields will be rendered. In doing so, it tackles styling issues with the current layout where content does not occupy the full height of the viewport, complicating panels pinned to the bottom, and disrupting "click outside" behavior for the currently selected block.
Testing instructions: