Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Fix crash when editing a component that uses RangeControl #27987

Merged
merged 10 commits into from
Jan 5, 2021
Merged

[RNMobile] Fix crash when editing a component that uses RangeControl #27987

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1ea8f94
Merge pull request #3 from WordPress/master
fluiddot Sep 18, 2020
b3e7e51
Merge pull request #4 from WordPress/master
fluiddot Sep 22, 2020
80b6df5
Merge pull request #5 from WordPress/master
fluiddot Sep 24, 2020
aadd803
Merge pull request #6 from WordPress/master
fluiddot Oct 1, 2020
351a225
Merge pull request #7 from WordPress/master
fluiddot Dec 21, 2020
ff8d204
Merge pull request #8 from WordPress/master
fluiddot Dec 23, 2020
8458b75
Merge pull request #9 from WordPress/master
fluiddot Dec 30, 2020
77abb11
Merge pull request #10 from WordPress/master
fluiddot Jan 4, 2021
1b39fe3
Merge pull request #11 from WordPress/master
fluiddot Jan 5, 2021
fa94310
Set onComplete handler as optional in Range cell component
fluiddot Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/components/src/mobile/bottom-sheet/range-cell.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ class BottomSheetRangeCell extends Component {
sliderValue: nextValue,
} );
onChange( nextValue );
onComplete( nextValue );
if ( onComplete ) {
onComplete( nextValue );
}
Comment on lines +74 to +76
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first attempt was to pass the handler in the Spacer block but then I realised that it would require to add it in more blocks so a better solution was to make it optional.

}

render() {
Expand Down