RichText: bypass paste filters for internal paste #27967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
force-pushed
the
try/internal-clipboard
branch
from
df8c35c to
f09f41d
Compare
|
Size Change: +167 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/internal-clipboard
branch
from
f09f41d to
1019f3f
Compare
ellatrix
requested review from
ajitbohra,
cameronvoell,
guarani,
nerrad and
ntwb
as code owners
ellatrix
changed the title
6 tasks
This was referenced Jun 29, 2021
|
The bug described in #33078 has led me to this PR. That bug is one of the visible issues stemming from RichText's bypass for internal pastes, but more issues appeared as I debugged this. As I see it, the root of the issue is the reliance on multiline tags ( *: when I say block, I really mean RichText instance Let me explain. The bug in #33078 happens as follows:
I was thinking of ways to fix this, but was quickly getting the sentiment that this isn't a one-off issue. Take the inverse situation:
@ellatrix, you have a ton on experience and a broader perspective over RichText, so I'd like to know what you think of this. But it seems to me that either the copying or the pasting should be lossier. I think it might also be an opportunity to assess whether this internal bypass is worth the tradeoffs (wanting to preserve internal styling annotations across copy/paste is laudable, but I wonder how much of an issue it is, given the complexity introduced). |
|
Instead of transferring the HTML, it would be better if we could transfer the rich text value itself so we don't need to call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently copy paste between rich text fields is completely handled by the browser, which comes with some downsides:
This is all useful when copy pasting external data, but not for internal data it can result in data loss. In rich text we allow a lot of custom and legacy formatting, which we don't allow through our paste filters for external data. Rich text should not run internally copied data through the paste filters and just accept it the way it was copied.
N.b.: setting clipboard data during copy/cut is not unprecedented. We already do this for selected blocks where we don't allow the browser to set unclean HTML.
How has this been tested?
Screenshots
Types of changes
Checklist: