-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor out CSS gradient from custom-gradient-bar #27936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Components
/packages/components
labels
Dec 30, 2020
@mkaz Thanks for the catch! The theme I was using only provided colors as |
mkaz
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated changes tested well, thanks for the quick fix.
Looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Components
/packages/components
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #26361 I wanted to reuse components from the gradient picker so they can share the same style and markup.
The old gradient bar worked directly with a CSS gradient string. This refactoring introduces an intermediate color-stop array to be used in the
CustomGradientBar
instead of that string. Then, at theCustomGradientPicker
level, the color-stop array can finally be converted back to the gradient string. This means that thegradientAST
doesn't need to be passed all the way down too. The logic remains fairly similar otherwise—I didn't want to make this a complete rewrite.How has this been tested?
Screenshots
No visual changes made. Markup generated should be identical.
Types of changes
Bug fix
Checklist: